Skip to content

Correction of readme.md#20

Open
radjivF wants to merge 1 commit into
alferov:masterfrom
hellozheat:master
Open

Correction of readme.md#20
radjivF wants to merge 1 commit into
alferov:masterfrom
hellozheat:master

Conversation

@radjivF

@radjivF radjivF commented Apr 28, 2016

Copy link
Copy Markdown

I just correct the readme. You don't need to declare Blop, if you do you will have an injection error, Cheers

@sngo25

sngo25 commented Oct 24, 2016

Copy link
Copy Markdown

Why is that? Isn't Blob an Angular service?

@radjivF

radjivF commented Oct 24, 2016

Copy link
Copy Markdown
Author

I guess Blob is a javascript object http://www.javascripture.com/Blob

@sngo25

sngo25 commented Oct 25, 2016

Copy link
Copy Markdown

Yes, but it's not available on every browsers so we need to inject Blob polyfill

@radjivF

radjivF commented Oct 25, 2016

Copy link
Copy Markdown
Author

I got an injection error when I did it. The only way to make it work was to take out in the dependencies injection.

@sngo25

sngo25 commented Oct 26, 2016

Copy link
Copy Markdown

Load dist/angular-file-saver.bundle.js then you are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants